Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Delete route - when user presses cancel, the route gets deleted #1660

Closed
tplevko opened this issue Nov 26, 2024 · 0 comments · Fixed by #1662
Closed

On Delete route - when user presses cancel, the route gets deleted #1660

tplevko opened this issue Nov 26, 2024 · 0 comments · Fixed by #1662
Assignees
@lordrip
Labels
bug Something isn't working
Milestone
2.3.0

Comments

@tplevko
Copy link
Contributor

tplevko commented Nov 26, 2024

Describe the Bug

When the user tries to cancel the route delete action, the route gets deleted anyway.

Steps to Reproduce the Bug or Issue

  1. Go to routes dropdown
  2. select delete route
  3. select cancel
  4. see the route gets deleted

Screenshots or Videos

vokoscreenNG-2024-11-26_07-55-24.mp4

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 0.30.0]
@tplevko tplevko added the bug Something isn't working label Nov 26, 2024
@apupier apupier moved this from New to Todo in Kanban Board Nov 26, 2024
@apupier apupier added this to the 2.3.0 milestone Nov 26, 2024
@lordrip lordrip self-assigned this Nov 26, 2024
@lordrip lordrip moved this from Todo to In Progress in Kanban Board Nov 26, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Nov 26, 2024
@lordrip
fix(FLowsList): Evaluate action confirmation when deleting a Flow
7b0f26e 
Currently, when deleting a flow, the confirmation modal is not properly
evaluated, leading to always deleting the flow regardlesas of the user
choice.

The fix is to check the return of the modal and act in consequence.

fix: KaotoIO#1660
lordrip added a commit to lordrip/kaoto that referenced this issue Nov 26, 2024
@lordrip
fix(FLowsList): Evaluate action confirmation when deleting a Flow
9e1bd9a 
Currently, when deleting a flow, the confirmation modal is not properly
evaluated, leading to always deleting the flow regardless of the user
choice.

The fix is to check the return of the modal and act in consequence.

fix: KaotoIO#1660
@lordrip lordrip mentioned this issue Nov 26, 2024
Merged
lordrip added a commit to lordrip/kaoto that referenced this issue Nov 26, 2024
@lordrip
fix(FLowsList): Evaluate action confirmation when deleting a Flow
54bcb82 
Currently, when deleting a flow, the confirmation modal is not properly
evaluated, leading to always deleting the flow regardless of the user
choice.

The fix is to check the return of the modal and act in consequence.

fix: KaotoIO#1660
@lordrip lordrip moved this from In Progress to In Review in Kanban Board Nov 26, 2024
lordrip added a commit that referenced this issue Nov 26, 2024
@lordrip
fix(FLowsList): Evaluate action confirmation when deleting a Flow
e2b4778 
Currently, when deleting a flow, the confirmation modal is not properly
evaluated, leading to always deleting the flow regardless of the user
choice.

The fix is to check the return of the modal and act in consequence.

fix: #1660
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Nov 26, 2024
lordrip added a commit to KaotoIO/kaoto-datamapper-integration that referenced this issue Dec 2, 2024
@lordrip
fix(FLowsList): Evaluate action confirmation when deleting a Flow
5f88bde 
Currently, when deleting a flow, the confirmation modal is not properly
evaluated, leading to always deleting the flow regardless of the user
choice.

The fix is to check the return of the modal and act in consequence.

fix: KaotoIO/kaoto#1660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
bug Something isn't working
Projects
Kanban Board
Status: Done
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

fix(FLowsList): Evaluate action confirmation when deleting a Flow lordrip/kaoto
3 participants
@apupier @tplevko @lordrip