Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring Camel K CR metadata #181

Closed
igarashitm opened this issue Oct 3, 2023 · 1 comment · Fixed by #233
Closed

Support configuring Camel K CR metadata #181

igarashitm opened this issue Oct 3, 2023 · 1 comment · Fixed by #233
Assignees
@igarashitm
Milestone
2.0.0 TP1

Comments

@igarashitm
Copy link
Contributor

igarashitm commented Oct 3, 2023 •
edited
Loading

Please describe the feature that you want to propose

Camel K CRs have metadata with the type Kubernetes meta/v1.ObjectMeta
https://camel.apache.org/camel-k/2.0.x/apis/camel-k.html#_camel_apache_org_v1_Pipe

We need to find a schema for this k8s ObjectMeta and combine with Camel K CRD. Also we would even need a dictionary for the well known annotations (/metadata/annotations) for Camel K so that user can choose what to add from.

Also see: apache/camel-k#4788
io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta is defined in kubernetes OpenAPI spec
https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/openapi-spec/swagger.json

It is suggested to configure traits through /metadata/annotations/trait.camel.apache.org/... although IntegrationSpec has traits.
@igarashitm igarashitm self-assigned this Oct 3, 2023
@igarashitm igarashitm moved this from New to In Progress in Kanban Board Oct 3, 2023
@igarashitm igarashitm added this to the 0.1.0 - Smart Connectors' MVP milestone Oct 3, 2023
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 5, 2023
@igarashitm
feat: Support configuring Camel K CR metadata
7490c1e 
Fixes: KaotoIO#181
@igarashitm igarashitm moved this from In Progress to Blocked in Kanban Board Oct 6, 2023
@igarashitm
Copy link
Contributor Author

Do #201 before this

igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 13, 2023
@igarashitm
feat: Support configuring Camel K CR metadata and Pipe errorHandler
84344b6 
Fixes: KaotoIO#181
@igarashitm igarashitm mentioned this issue Oct 13, 2023
Closed
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 16, 2023
@igarashitm
feat: Support configuring Camel K CR metadata and Pipe errorHandler
e58f8bf 
Fixes: KaotoIO#181
@igarashitm igarashitm moved this from Blocked to In Progress in Kanban Board Oct 17, 2023
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 17, 2023
@igarashitm
feat: Support configuring Camel K CR metadata (KaotoIO#181)
8e18e57 
Add schema for k8s metadata and Pipe errorHandler
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 17, 2023
@igarashitm
feat: Support configuring Camel K CR metadata (KaotoIO#181)
7763cc2 
Add schema for k8s metadata and Pipe errorHandler
igarashitm added a commit that referenced this issue Oct 17, 2023
@igarashitm
feat: Support configuring Camel K CR metadata (#181) (#226)
31aba1a 
Add schema for k8s metadata and Pipe errorHandler
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 20, 2023
@igarashitm
feat: Support configuring Camel K CR metadata and Pipe errorHandler
8de2150 
Fixes: KaotoIO#181
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 20, 2023
@igarashitm
feat: Support configuring Camel K CR metadata and Pipe errorHandler
bbac5a7 
Fixes: KaotoIO#181
Also partially addresses KaotoIO#188, need more work for supporting JSON schema `oneOf`
@igarashitm igarashitm mentioned this issue Oct 20, 2023
Merged
igarashitm added a commit to igarashitm/kaoto that referenced this issue Oct 20, 2023
@igarashitm
feat: Support configuring Camel K CR metadata and Pipe errorHandler
8765d99 
Fixes: KaotoIO#181
Also partially addresses KaotoIO#188, need more work for supporting JSON schema `oneOf`
igarashitm added a commit that referenced this issue Oct 20, 2023
@igarashitm
feat: Support configuring Camel K CR metadata and Pipe errorHandler (#…
e7ccfd7 
…233)

* feat: Support configuring Camel K CR metadata and Pipe errorHandler

Fixes: #181
Also partially addresses #188, need more work for supporting JSON schema `oneOf`

* chore: Reflect review comments
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kanban Board Oct 20, 2023
@lhein lhein modified the milestones: Smart Connectors' MVP, Feature Parity Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igarashitm igarashitm

Labels
None yet
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP1
2 participants
@igarashitm @lhein