Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show content of unrecognized nodes in the config form #309

Closed
lordrip opened this issue Nov 8, 2023 · 1 comment · Fixed by #644
Closed

Show content of unrecognized nodes in the config form #309

lordrip opened this issue Nov 8, 2023 · 1 comment · Fixed by #644
Assignees
@tplevko
Labels
canvas/visualization Canvas-related issues enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
2.0.0 TP1

Comments

@lordrip
Copy link
Member

lordrip commented Nov 8, 2023

Please describe the feature that you want to propose

Currently, we're displaying an empty panel for unknown nodes.
image

Goal

In case an unknown node is open, it should be beneficial to display the YAML representation of it, this way the user could know what the node is referring to.

This could be done with a simple <pre> and <code> tag showing a parsed version of the node.

The content of the node it's already available in the in the CanvasForm component
@lordrip lordrip added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed canvas/visualization Canvas-related issues labels Nov 8, 2023
@lordrip lordrip added this to the Polishing UI/UX post parity milestone Nov 8, 2023
@lordrip
Copy link
Member Author

lordrip commented Nov 8, 2023

kudos to @brunoNetId for the idea 💪

@lhein lhein moved this from New to Todo in Kanban Board Nov 8, 2023
@tplevko tplevko self-assigned this Jan 12, 2024
@tplevko tplevko mentioned this issue Jan 15, 2024
Merged
@lordrip lordrip modified the milestones: 2.0.0, 2.0.0 TP2 Jan 16, 2024
@lordrip lordrip moved this from Todo to In Progress in Kanban Board Jan 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kanban Board Jan 16, 2024
@lhein lhein modified the milestones: 2.0.0 TP2, 2.0.0 TP1 Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tplevko tplevko

Labels
canvas/visualization Canvas-related issues enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP1
Development

Successfully merging a pull request may close this issue.

fix(309): Add codeblock to unknown node tplevko/kaoto-next
3 participants
@lhein @tplevko @lordrip