Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nodes does not always work #370

Closed
lhein opened this issue Nov 19, 2023 · 0 comments · Fixed by #413
Closed

Replace nodes does not always work #370

lhein opened this issue Nov 19, 2023 · 0 comments · Fixed by #413
Labels
bug Something isn't working canvas/visualization Canvas-related issues
Milestone
2.0.0 TP1

Comments

@lhein
Copy link
Contributor

lhein commented Nov 19, 2023 •
edited
Loading

When replacing nodes on the canvas it sometimes happens that the original node isn't replaced but the replacement gets appended to the original node. (see video)

Image
@lhein lhein converted this from a draft issue Nov 19, 2023
@lhein lhein added this to the Feature Parity milestone Nov 19, 2023
@lhein lhein moved this from New to Todo in Kanban Board Nov 19, 2023
@lhein lhein added bug Something isn't working canvas/visualization Canvas-related issues labels Nov 19, 2023
@lordrip lordrip moved this from Todo to In Progress in Kanban Board Nov 22, 2023
@lordrip lordrip assigned lordrip and unassigned lordrip Nov 22, 2023
@lordrip lordrip moved this from In Progress to Todo in Kanban Board Nov 22, 2023
@lordrip lordrip moved this from Todo to In Progress in Kanban Board Nov 22, 2023
@lordrip lordrip moved this from In Progress to Todo in Kanban Board Nov 22, 2023
@lhein lhein assigned lhein and unassigned lhein Nov 22, 2023
@lordrip lordrip moved this from Todo to In Progress in Kanban Board Nov 23, 2023
lordrip added a commit to lordrip/kaoto that referenced this issue Nov 23, 2023
@lordrip
fix(canvas): Replace nodes that contains a single steps property don'…
f8bce9d 
…t work

Currently, there's a piece of logic that checks if the node meant to be replaced has a single
`step` property that can have children. This logic was causing that for some special nodes,
like `doCatch`, the replace step functionality didn't work, and the intended replacement
step gets appended instead.

The fix is to remove said functionality as it was already implemented in a different manner.

Fixes: KaotoIO#370
@lordrip lordrip mentioned this issue Nov 23, 2023
Merged
@lordrip lordrip moved this from In Progress to In Review in Kanban Board Nov 23, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working canvas/visualization Canvas-related issues
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP1
Development

Successfully merging a pull request may close this issue.

fix(canvas): Replace nodes that contains a single steps property don't work lordrip/kaoto
2 participants
@lhein @lordrip