Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use all available space for unknown node types instead of having a scrollbar #824

Closed
apupier opened this issue Feb 9, 2024 · 0 comments · Fixed by #871
Closed

Use all available space for unknown node types instead of having a scrollbar #824

apupier opened this issue Feb 9, 2024 · 0 comments · Fixed by #871
Assignees
@lordrip
Labels
canvas/config-form Configuration form related issues enhancement New feature or request ui/ux This issue is about improving the UI / UX
Milestone
2.0.0 TP2

Comments

@apupier
Copy link
Member

apupier commented Feb 9, 2024

Please describe the feature that you want to propose

image

there is enough room at the bottom to avoid having a scrollbar
@apupier apupier added enhancement New feature or request canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX labels Feb 9, 2024
@lhein lhein moved this from New to Todo in Kanban Board Feb 10, 2024
@lhein lhein moved this from Todo to Backlog in Kanban Board Feb 10, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Feb 26, 2024
@lordrip
fix(CanvasForm): Scrollbar overlapping controls
9cf3e9e 
Currently, the `CanvasForm` component shows its scrollbars on top of the
form controls, effectively blocking adding or removing elements from an
Array.

The fix is to:
1. Make the `<Card>` component take the entire height available without
   scroll
2. Make the `CanvasForm` body to have `scroll: auto`, this way, the
   scroll bar will be drawn outside of the container, as opposed as it
   was before, where the form had the scroll

fix: KaotoIO#847
fix: KaotoIO#824
@lordrip lordrip mentioned this issue Feb 26, 2024
Merged
@lordrip lordrip moved this from Backlog to In Progress in Kanban Board Feb 26, 2024
@lordrip lordrip added this to the 2.0.0 TP2 milestone Feb 26, 2024
@lordrip lordrip self-assigned this Feb 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kanban Board Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
canvas/config-form Configuration form related issues enhancement New feature or request ui/ux This issue is about improving the UI / UX
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP2
Development

Successfully merging a pull request may close this issue.

fix(CanvasForm): Scrollbar overlapping controls lordrip/kaoto
2 participants
@apupier @lordrip