Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Warn users when trying to delete a container #1062

Merged
merged 1 commit into from
May 8, 2024

Conversation

shivamG640
Copy link
Contributor

Fixes #1042

@shivamG640 shivamG640 force-pushed the Fix_1042 branch 2 times, most recently from 105c3b4 to be5ddc5 Compare May 6, 2024 06:54
@shivamG640 shivamG640 marked this pull request as ready for review May 7, 2024 08:43
Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the behavior doesn't corresponds to the title neither the initial issue:

@shivamG640
Copy link
Contributor Author

the behavior doesn't corresponds to the title neither the initial issue:

the behavior doesn't corresponds to the title neither the initial issue:

Thanks for the review and comment @apupier

  • The Modal only appears for those step which can have children or special children components. The For all the containers as well. check here: https://shivamg640.github.io/kaoto/
  • The message on the Modal is not clear as of now. We Plan to improve it for sure!

@shivamG640 shivamG640 force-pushed the Fix_1042 branch 3 times, most recently from abadba0 to 0e7af9d Compare May 7, 2024 16:45
@lhein
Copy link
Contributor

lhein commented May 8, 2024

I would slightly rephrase the dialog texts...

Title: Delete multiple steps
Text: You are about to delete multiple steps from your integration. Are you sure?

Additionally I spotted another issue...if you for instance add an empty "filter" component, the dialog pops up too regardless if the filter has children or not.

@shivamG640 shivamG640 force-pushed the Fix_1042 branch 2 times, most recently from f98550d to b315555 Compare May 8, 2024 09:43
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the text changes

@shivamG640 shivamG640 force-pushed the Fix_1042 branch 2 times, most recently from 6141bd8 to 230e418 Compare May 8, 2024 10:15
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this.

There's a remaining issue that will be tackled on an upcoming PR, about deleting the from node, which states that steps will be removed, which it's not the case

@lordrip lordrip merged commit c7fec53 into KaotoIO:main May 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn users when trying to delete a container step
4 participants