Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog): Add runtime selector #1182

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Jun 20, 2024

Context

Adapt UI to accommodate the newly generated catalog library

fix: #1109

@lordrip lordrip force-pushed the feat/catalog-selector branch 5 times, most recently from 0fb054a to 9bc9507 Compare June 20, 2024 12:29
@lordrip lordrip force-pushed the feat/catalog-selector branch from 9bc9507 to a095d71 Compare June 20, 2024 13:51
@lordrip lordrip marked this pull request as ready for review June 20, 2024 13:52
@lordrip lordrip force-pushed the feat/catalog-selector branch 4 times, most recently from f812cff to 1d7b58c Compare June 24, 2024 12:12
@lordrip lordrip marked this pull request as draft June 24, 2024 12:12
@lordrip lordrip force-pushed the feat/catalog-selector branch 2 times, most recently from 6a2fc31 to edf212f Compare June 24, 2024 15:45
* Context
Adapt UI to accommodate the newly generated catalog library

fix: KaotoIO#1109
@lordrip lordrip force-pushed the feat/catalog-selector branch from edf212f to c6291c6 Compare June 24, 2024 16:10
@lordrip lordrip marked this pull request as ready for review June 25, 2024 06:44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the parent folder to camel-catalog-plugin? or not a convention in javscript world to match the folder name with the artifact name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder will be removed after we merged all related PRs 😃

Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • maybe nice to add the Camel version for Camel Quarkus, somethign like Camel Quarkus 3.12.0 (based on Camel X.Y.Z)
  • works great in VS Code

@lordrip
Copy link
Member Author

lordrip commented Jun 25, 2024

  • maybe nice to add the Camel version for Camel Quarkus, somethign like Camel Quarkus 3.12.0 (based on Camel X.Y.Z)
  • works great in VS Code

That's a good idea. Currently, the version shown comes directly from the Camel Catalog (Quarkus), I'll create another PR for the java part to rename the version in a similar fashion as you suggested

@lordrip lordrip merged commit 724bb94 into KaotoIO:main Jun 25, 2024
9 of 10 checks passed
@lordrip lordrip deleted the feat/catalog-selector branch June 25, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support different Camel catalog versions
2 participants