e2e for selecting catalog versions #1212
Conversation
tplevko
force-pushed
the
e2e_catalog_version
branch
2 times, most recently
from
3355132 to
61a57e4
Compare
packages/ui-tests/cypress/e2e/designer/catalogs/quarkusCatalog.cy.ts
Outdated
Show resolved
Hide resolved
tplevko
force-pushed
the
e2e_catalog_version
branch
2 times, most recently
from
6ee573f to
1bba1ab
Compare
tplevko
force-pushed
the
e2e_catalog_version
branch
from
1bba1ab to
de831a3
Compare
tplevko
force-pushed
the
e2e_catalog_version
branch
6 times, most recently
from
19c7447 to
ee0457c
Compare
| cy.checkCatalogVersion(elementVersion); | ||
| }); | ||
|
|
||
| cy.chooseFromCatalog('component', 'as2'); |
There was a problem hiding this comment.
What do you think about testing with a component which is available only in SpringBoot catalog? It would ensure that the correct catalog is loaded.
I'm not sure that there is one unfortunately. But maybe a component not available in Quarkus, such as spring-event
There was a problem hiding this comment.
this is a good point - changed to spring-event
| cy.openSettings(); | ||
| cy.interactWithConfigInputObject( | ||
| 'catalogUrl', | ||
| 'https://raw.githubusercontent.com/tplevko/kaoto-catalog-test/main/index.json', |
There was a problem hiding this comment.
I think this should be hosted either in a src test folder of this repository or its own repository in KaotoIO.
Also usually a good idea to point to a tag so that the test does not break on main branch here because of changes on the other repository
There was a problem hiding this comment.
By default, we're not setting a catalog URL, so what about testing adding http://localhost:5173/camel-catalog/index.json instead? The advantage would be that while we are still checking that we can set a URL, we benefit from using what's already provided.
There was a problem hiding this comment.
Update: I tested it and it works 👍
There was a problem hiding this comment.
yes, this should be also usable - changed the test to use http://localhost:5173/camel-catalog/index.json by default
| // Wait for the element to become visible | ||
| cy.get('[data-testid="visualization-empty-state"]').should('be.visible'); |
There was a problem hiding this comment.
I do not see an explicit wait. So etiher there is no wait or it is by default of the cy.get and in both cases I think we can remove the comment
There was a problem hiding this comment.
thanks for pointing this out - removed the comment
tplevko
force-pushed
the
e2e_catalog_version
branch
2 times, most recently
from
01caf3f to
84f4625
Compare
tplevko
force-pushed
the
e2e_catalog_version
branch
from
84f4625 to
311b0dd
Compare
fix: #1109