Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vscode): Remove isHidden warning from KaotoEditor component #1220

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix(vscode): Remove isHidden warning from KaotoEditor component #1220

merged 1 commit into from
Jul 1, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Jun 28, 2024 •
edited
Loading

Remove VSCode Kaoto warning

Warning: React does not recognize the `isHidden` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `ishidden` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

image

fixes: KaotoIO/vscode-kaoto#436

@lordrip lordrip force-pushed the fix/remove-ishidden-warning branch from a35f1f1 to 4dc369a Compare June 28, 2024 19:46
@lordrip lordrip requested a review from apupier June 28, 2024 19:51
@apupier
Copy link
Member

apupier commented Jun 28, 2024

fixes KaotoIO/vscode-kaoto#436

@apupier apupier merged commit 06cbd2c into KaotoIO:main Jul 1, 2024
9 checks passed
@lordrip lordrip deleted the fix/remove-ishidden-warning branch July 2, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apupier apupier apupier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lordrip @apupier