feat(vscode): Provide SettingsAdapter for VSCode #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
commented
Jul 24, 2024
lordrip
commented
Jul 24, 2024
lordrip
force-pushed
the
feat/vscode-settings-adapter
branch
from
4094d28 to
da4cd4b
Compare
lordrip
commented
Jul 24, 2024
lordrip
commented
Jul 24, 2024
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 24, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
apupier
approved these changes
Jul 25, 2024
packages/ui/src/multiplying-architecture/KaotoEditorChannelApi.ts
Outdated
Show resolved
Hide resolved
At the moment, the Kaoto settings are passed individually to VSCode, meaning that in case we want to add new settings, we need to pass individual parameters to the `KaotoEditorApp` class. This commit provides a SettingsAdapter so every new setting will be added directly to the adapter. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO#1221
lordrip
force-pushed
the
feat/vscode-settings-adapter
branch
from
da4cd4b to
4737412
Compare
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 25, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 25, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 25, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 25, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 29, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 29, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 29, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 29, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 30, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to KaotoIO/vscode-kaoto
that referenced
this pull request
Jul 30, 2024
This commit adds a new `getVSCodeKaotoSettings` method to the `VSCodeKaotoEditorChannelApi` class to build the Settings model. It also deprecates the existing `getCatalogURL` method as the new way to go is using the settings adapter from now on. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 30, 2024
This commit wires up the `nodeLabel` setting so the user can choose what label a node shows. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 30, 2024
This commit wires up the `nodeLabel` setting so the user can choose what label a node shows. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 30, 2024
This commit wires up the `nodeLabel` setting so the user can choose what label a node shows. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to lordrip/vscode-kaoto
that referenced
this pull request
Jul 30, 2024
This commit wires up the `nodeLabel` setting so the user can choose what label a node shows. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
lordrip
added a commit
to KaotoIO/vscode-kaoto
that referenced
this pull request
Jul 31, 2024
This commit wires up the `nodeLabel` setting so the user can choose what label a node shows. relates: https://issues.redhat.com/browse/KTO-441 relates: KaotoIO/kaoto#1221 relates: KaotoIO/kaoto#1264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the Kaoto settings are passed individually to VSCode, meaning that in case we want to add new settings, we need to pass individual parameters to the
KaotoEditorAppclass.This commit provides a SettingsAdapter so every new setting will be added directly to the adapter.
relates: https://issues.redhat.com/browse/KTO-441
relates: #1221