fix(Canvas): Remove mobx warnings from @patternfly/react-topology #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening and closing the configuration tab, mobx warnings are thrown, coming from the @patternfly/react-topology library. The fix is to wrap any operation to the canvas inside of an `action` callback, so mobx can notify the consumers that something changed. fix: KaotoIO#1294
lordrip
force-pushed
the
fix/mobx-warnings
branch
from
82df317 to
de80a9f
Compare
tplevko
approved these changes
Aug 8, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When opening and closing the configuration tab, mobx warnings are thrown from the @patternfly/react-topology library.
The fix is to wrap any operation to the canvas inside of an
actioncallback, so mobx can notify the consumers that something changed.fix: #1294