Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stories for about modal and settings form #1296

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Aug 8, 2024

No description provided.

@tplevko tplevko marked this pull request as ready for review August 8, 2024 12:24
return (
<>
<button onClick={() => setIsModalOpen(true)}>Open Kaoto About Modal</button>
<KaotoAboutModal {...args} handleCloseModal={handleClose} isModalOpen={isModalOpen} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, for some reason the modal is not open 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's strange, for some reason, the snapshot taken displayed the button, instead of the modal. Removing the button seems to fix the problem

@lordrip lordrip merged commit 45c4d2f into KaotoIO:main Aug 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants