chore(Canvas): Update @patternfly/react-topology
#1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhein
approved these changes
Aug 9, 2024
Now that patternfly/react-topology#230 is completed, we can remove the extended version of the `DagreGroupsLayout` and use the library directly. relates: patternfly/react-topology#230
lhein
force-pushed
the
chore/update-react-topology
branch
from
2b24c02 to
4a01067
Compare
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Aug 9, 2024
After upgrading [`@patternfly/react-topology`](KaotoIO#1302) calculating the layout inside of Kaoto is not needed anymore, so `@dagre/dagrejs` is also not needed. relates: patternfly/react-topology#230
lordrip
added a commit
that referenced
this pull request
Aug 9, 2024
After upgrading [`@patternfly/react-topology`](#1302) calculating the layout inside of Kaoto is not needed anymore, so `@dagre/dagrejs` is also not needed. relates: patternfly/react-topology#230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Now that patternfly/react-topology#230 is completed, we can remove the extended version of the
DagreGroupsLayoutand use the library directly.kudos to @jeff-phillips-18 for the quick response 👏
relates: patternfly/react-topology#230