Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Extract peerDependencies #1307

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Aug 9, 2024

Context

In order to use @kaoto/kaoto in other apps, we need to externalize its peerDependencies so the user can use the already existing react and @patternfly/* versions

@lordrip lordrip marked this pull request as draft August 9, 2024 16:00
@lordrip lordrip force-pushed the feat/extract-peerdependencies branch 3 times, most recently from 40690bc to 874480e Compare August 9, 2024 16:17
@lordrip lordrip marked this pull request as ready for review August 9, 2024 16:27
In order to use `@kaoto/kaoto` in other apps, we need to externalize its
`peerDependencies` so the user can use the already existing `react` and
`@patternfly/*` versions
@lordrip lordrip force-pushed the feat/extract-peerdependencies branch from 874480e to 7378547 Compare August 9, 2024 16:29
@lordrip lordrip merged commit d344460 into KaotoIO:main Aug 9, 2024
9 checks passed
@lordrip lordrip deleted the feat/extract-peerdependencies branch August 9, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant