Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create RouteVisualization component for external applications usage. #1319

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

mmelko
Copy link
Contributor

@mmelko mmelko commented Aug 15, 2024

fix: #472

@mmelko mmelko changed the title feat: Create RouteVisualization component for external applications u… feat: Create RouteVisualization component for external applications usage. Aug 15, 2024
@@ -28,7 +28,7 @@
"@testing-library/jest-dom",
]
},
"include": ["src/public-api.ts", "src/models-api.ts", "src/testing-api.ts", "src/global.d.ts"],
"include": ["src/public-api.ts", "src/models-api.ts", "src/testing-api.ts","src/components-api.ts", "src/global.d.ts"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this on the other tsconfig.json as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that implicitly inherited by "extends": "./tsconfig.esm.json", ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. Here's the extension

@lordrip lordrip merged commit 187c7cf into KaotoIO:main Aug 16, 2024
9 checks passed
@lordrip lordrip mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reusable Visualization
2 participants