Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Canvas): Split CanvasService in ControllerService and FlowService #1335

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Aug 19, 2024

Context

Split CanvasService for better separation of concerns.

fix: #1329

@lordrip lordrip force-pushed the chore/split-canvas-service branch from fb0da39 to 72f8b25 Compare August 19, 2024 17:40
@lordrip lordrip force-pushed the chore/split-canvas-service branch from 72f8b25 to e939cb7 Compare August 19, 2024 17:49
…Service`

Split `CanvasService` for better separation of concerns.

fix: KaotoIO#1329
@lordrip lordrip force-pushed the chore/split-canvas-service branch from e939cb7 to 1d03cc7 Compare August 19, 2024 17:50
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@a72d5f2). Learn more about missing BASE report.

Files Patch % Lines
...rc/components/Visualization/Canvas/flow.service.ts 97.56% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1335   +/-   ##
=======================================
  Coverage        ?   79.21%           
=======================================
  Files           ?      227           
  Lines           ?     5244           
  Branches        ?     1354           
=======================================
  Hits            ?     4154           
  Misses          ?     1086           
  Partials        ?        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 19, 2024

@lordrip lordrip merged commit bf32635 into KaotoIO:main Aug 19, 2024
12 checks passed
@lordrip lordrip deleted the chore/split-canvas-service branch August 19, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom visualization for EIPs
1 participant