Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e on exception cleanup - use predefined selector #1365

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Aug 30, 2024

No description provided.

Copy link

sonarcloud bot commented Aug 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e794ff7). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1365   +/-   ##
=======================================
  Coverage        ?   67.24%           
  Complexity      ?       25           
=======================================
  Files           ?      264           
  Lines           ?     7563           
  Branches        ?     1469           
=======================================
  Hits            ?     5086           
  Misses          ?     2474           
  Partials        ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tplevko tplevko marked this pull request as ready for review August 30, 2024 09:40
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way cleaner this way 👍

@lordrip lordrip merged commit 1ede935 into KaotoIO:main Aug 30, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants