Improve Catalog Performance #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
=======================================
Coverage ? 67.20%
Complexity ? 25
=======================================
Files ? 264
Lines ? 7592
Branches ? 1474
=======================================
Hits ? 5102
Misses ? 2487
Partials ? 3 ☔ View full report in Codecov by Sentry. |
lordrip
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Functionality-wise, LGTM, thanks a lot @shivamG640 for taking care.
I just left a couple of items to take care for 💅
| @@ -30,7 +30,6 @@ export const camelComponentToTile = (componentDef: ICamelComponentDefinition): I | |||
| tags, | |||
| provider, | |||
| version, | |||
| rawObject: componentDef, | |||
shivamG640
commented
Sep 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1194
Fixes #252
Also Removed RawProperties from the Tile.