Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidebar width preserve in local storage #1370

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Sep 2, 2024

Store the user specified sidebar width in local storage persisting the width even when switching tabs in the UI.

vokoscreenNG-2024-09-02_09-45-24.mp4

Copy link

sonarcloud bot commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6d1c35b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../ui/src/components/Visualization/Canvas/Canvas.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1370   +/-   ##
=======================================
  Coverage        ?   67.27%           
  Complexity      ?       25           
=======================================
  Files           ?      264           
  Lines           ?     7568           
  Branches        ?     1504           
=======================================
  Hits            ?     5091           
  Misses          ?     2474           
  Partials        ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tplevko tplevko marked this pull request as ready for review September 2, 2024 08:50
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care @tplevko

@lordrip lordrip merged commit 7d9abe0 into KaotoIO:main Sep 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants