Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog-generator): Add "parameters" property #1371

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Sep 2, 2024

Context

Currently, the parameters property is only added for ToDynamicDefinition EIP.

This represents a problem for Camel 4.8.0 since there's a new poll EIP that requires it.

Currently, the `parameters` property is only added for
`ToDynamicDefinition` EIP.

This represents a problem for Camel 4.8.0 since there's a new `poll` EIP
that requires it.
@lordrip lordrip force-pushed the fix/include-parameters-prop branch from e24093d to 58af50e Compare September 2, 2024 16:39
Copy link

sonarcloud bot commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@7d9abe0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../camelcatalog/generator/CamelCatalogProcessor.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1371   +/-   ##
=======================================
  Coverage        ?   67.26%           
  Complexity      ?       25           
=======================================
  Files           ?      264           
  Lines           ?     7569           
  Branches        ?     1504           
=======================================
  Hits            ?     5091           
  Misses          ?     2421           
  Partials        ?       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lhein lhein merged commit dc54036 into KaotoIO:main Sep 3, 2024
12 checks passed
@lordrip lordrip deleted the fix/include-parameters-prop branch September 17, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants