Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(schema): Migrate all JSON Schemas to draft-07 #1384

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

shivamG640
Copy link
Contributor

Fixes #1205

@shivamG640 shivamG640 force-pushed the Fix_1205 branch 2 times, most recently from 2011124 to 8c664c8 Compare September 4, 2024 16:09
@shivamG640
Copy link
Contributor Author

Hi @lordrip ,
Please review this PR.
I check the following components and they are working perfectly:
Timer component, log processor, Routeconfiguartion, Restconfiguartion, errorhandler, kamelet, pipe.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@845ba63). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...amelcatalog/generator/CatalogGeneratorBuilder.java 0.00% 4 Missing ⚠️
...catalog/generator/CamelYamlDslSchemaProcessor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1384   +/-   ##
=======================================
  Coverage        ?   66.99%           
  Complexity      ?       25           
=======================================
  Files           ?      265           
  Lines           ?     7565           
  Branches        ?     1473           
=======================================
  Hits            ?     5068           
  Misses          ?     2494           
  Partials        ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivamG640 shivamG640 force-pushed the Fix_1205 branch 2 times, most recently from b9fc0b9 to 028e9de Compare September 4, 2024 21:16
@shivamG640 shivamG640 requested a review from lordrip September 5, 2024 07:10
@shivamG640 shivamG640 marked this pull request as ready for review September 5, 2024 07:10
@shivamG640
Copy link
Contributor Author

I tested few processors in the source-code and it all looks good:
bean, aggreate, circuitBreaker, convertVariableTo, delay, enrich

Copy link

sonarcloud bot commented Sep 5, 2024

@lordrip lordrip merged commit 50c745f into KaotoIO:main Sep 5, 2024
12 checks passed
@shivamG640 shivamG640 deleted the Fix_1205 branch September 5, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate all JSON Schemas to draft-07
2 participants