chore(VSCode): Refactor KaotoEditor structure #1386
Conversation
| { | ||
| path: Links.PipeErrorHandler, | ||
| lazy: async () => import('../pages/PipeErrorHandler'), | ||
| }, |
There was a problem hiding this comment.
@apupier we could add an About tab here.
| @@ -30,19 +31,6 @@ export class KaotoEditorApp implements Editor { | |||
| this.editorRef = createRef<EditorApi>(); | |||
| } | |||
|
|
|||
| async getElementPosition() { | |||
| } | ||
| aria-label="Design canvas" | ||
| > | ||
| <DesignTab /> |
There was a problem hiding this comment.
No more linking components directly, the router will take care of mounting the right component when needed.
| <CatalogModalProvider> | ||
| <DeleteModalContextProvider>{props.children}</DeleteModalContextProvider> | ||
| </CatalogModalProvider> |
There was a problem hiding this comment.
These providers already come directly from the DesignPage, so they are no longer needed here.
Currently, the `DesignPage` component is duplicated to serve the multiplying architecture and the webapp. In addition to that, for the multiplying architecture, we're using a React render approach to navigate between different tabs, whereas in the webapp we use a Router. This commit removes the `Tabs` folder and use the `DesignPage` component directly to reduce the duplication. In addition to that, a Router has been introduced to navigate between the tabs, this as a cleanup for the upcoming tasks.
lordrip
force-pushed
the
chore/refactor-vscode-editor-structure
branch
from
ec2026d to
478d37c
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
=======================================
Coverage ? 67.01%
Complexity ? 25
=======================================
Files ? 265
Lines ? 7563
Branches ? 1473
=======================================
Hits ? 5068
Misses ? 2492
Partials ? 3 ☔ View full report in Codecov by Sentry. |
Context
Currently, the
DesignPagecomponent is duplicated to serve the multiplying architecture and the webapp.In addition to that, for the multiplying architecture, we're using a React render approach to navigate between different tabs, whereas in the web app we use a Router.
This commit removes the
Tabsfolder and uses theDesignPagecomponent directly to reduce the duplication.In addition to that, a Router has been introduced to navigate between the tabs, this is a cleanup for the upcoming tasks.