Fix(canvas): Display multicast/loadbalance as parallel executed processes #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1431 +/- ##
=======================================
Coverage ? 67.71%
Complexity ? 25
=======================================
Files ? 269
Lines ? 7644
Branches ? 1520
=======================================
Hits ? 5176
Misses ? 2408
Partials ? 60 ☔ View full report in Codecov by Sentry. |
|
|
shivamG640
force-pushed
the
Fix_1347
branch
4 times, most recently
from
b177c11 to
178ab52
Compare
|
I am wondering if the quality check makes sense for test classes in this specific case. |
shivamG640
force-pushed
the
Fix_1347
branch
2 times, most recently
from
6b97379 to
9eca9e9
Compare
lordrip
reviewed
Sep 16, 2024
packages/ui/src/models/visualization/visualization-node.test.ts
Outdated
Show resolved
Hide resolved
.../ui/src/models/visualization/flows/nodes/mappers/parallel-processor-base-node-mapper.test.ts
Outdated
Show resolved
Hide resolved
| expect(vizNode).toBeDefined(); | ||
| expect(vizNode.data).toMatchObject({ | ||
| path, | ||
| icon: expect.any(String), |
shivamG640
force-pushed
the
Fix_1347
branch
2 times, most recently
from
a7e8297 to
2596938
Compare
lordrip
reviewed
Sep 16, 2024
.../ui/src/models/visualization/flows/nodes/mappers/parallel-processor-base-node-mapper.test.ts
Outdated
Show resolved
Hide resolved
lordrip
reviewed
Sep 16, 2024
packages/ui/src/models/visualization/flows/nodes/mappers/parallel-processor-base-node-mapper.ts
Outdated
Show resolved
Hide resolved
Comment on lines
54
to
62
| addNodeInteraction(vizNode: IVisualizationNode, processorName: keyof ProcessorDefinition): void { | ||
| const stepsProperties = CamelComponentSchemaService.getProcessorStepsProperties(processorName); | ||
| const canHaveChildren = stepsProperties.find((property) => property.type === 'branch') !== undefined; | ||
| const canHaveSpecialChildren = Object.keys(stepsProperties).length > 1; | ||
| const canReplaceStep = CamelComponentSchemaService.canReplaceStep(processorName); | ||
| const canRemoveStep = !CamelComponentSchemaService.DISABLED_REMOVE_STEPS.includes(processorName); | ||
| const canBeDisabled = CamelComponentSchemaService.canBeDisabled(processorName); | ||
|
|
||
| vizNode.setNodeInteraction({ | ||
| canHavePreviousStep: false, | ||
| canHaveNextStep: false, | ||
| canRemoveFlow: false, | ||
| canHaveChildren, | ||
| canHaveSpecialChildren, | ||
| canReplaceStep, | ||
| canRemoveStep, | ||
| canBeDisabled, | ||
| }); | ||
| } |
There was a problem hiding this comment.
This also seems very similar to the abstract-camel-visual-entity counterpart.
There was a problem hiding this comment.
We can take care of this in another PR, so we can also remove the other duplication from other visual entities as well.
There was a problem hiding this comment.
Created a task for this- #1445
shivamG640
force-pushed
the
Fix_1347
branch
3 times, most recently
from
0552f29 to
d3dea74
Compare
shivamG640
force-pushed
the
Fix_1347
branch
from
d3dea74 to
8419b9a
Compare
lordrip
reviewed
Sep 17, 2024
packages/ui/src/models/visualization/visualization-node.test.ts
Outdated
Show resolved
Hide resolved
lordrip
approved these changes
Sep 17, 2024
lordrip
reviewed
Sep 17, 2024
packages/ui/src/models/visualization/visualization-node.test.ts
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1347
Fixes #648
Test this change here.