Fix(canvas): Show confirmation dialog for replacing a step with children #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
=======================================
Coverage ? 68.63%
Complexity ? 25
=======================================
Files ? 269
Lines ? 7716
Branches ? 1532
=======================================
Hits ? 5296
Misses ? 2371
Partials ? 49 ☔ View full report in Codecov by Sentry. |
shivamG640
force-pushed
the
Fix_1433
branch
from
94a9cab to
f4a61d8
Compare
shivamG640
force-pushed
the
Fix_1433
branch
from
f4a61d8 to
73037d6
Compare
shivamG640
force-pushed
the
Fix_1433
branch
from
73037d6 to
97fe010
Compare
|
lordrip
approved these changes
Sep 19, 2024
| @@ -0,0 +1,37 @@ | |||
| import { fireEvent, render } from '@testing-library/react'; | |||
There was a problem hiding this comment.
Awesome, thanks a lot for adding tests 💪
| @@ -102,6 +103,30 @@ describe('FlowsList.tsx', () => { | |||
| expect(onCloseSpy).toHaveBeenCalledTimes(1); | |||
| }); | |||
|
|
|||
| it('should show delete confirmation modal when clicking on a delete icon', async () => { | |||
There was a problem hiding this comment.
Awesome, thanks a lot for adding tests 💪
| @@ -0,0 +1,54 @@ | |||
| import { fireEvent, render, waitFor } from '@testing-library/react'; | |||
There was a problem hiding this comment.
Awesome, thanks a lot for adding tests 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1433