feat(CanvasForm): Add title API #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
feat/add-settitle-api
branch
from
9a82a2a to
dc3f4a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
=======================================
Coverage ? 68.21%
Complexity ? 25
=======================================
Files ? 269
Lines ? 7657
Branches ? 1481
=======================================
Hits ? 5223
Misses ? 2431
Partials ? 3 ☔ View full report in Codecov by Sentry. |
lordrip
force-pushed
the
feat/add-settitle-api
branch
from
dc3f4a1 to
3145bdb
Compare
igarashitm
approved these changes
Sep 17, 2024
lordrip
force-pushed
the
feat/add-settitle-api
branch
from
3145bdb to
9da84ad
Compare
Currently, there's no mechanism for setting the Canvas Form title per component. This commit adds that possibility.
lordrip
force-pushed
the
feat/add-settitle-api
branch
from
9da84ad to
097f219
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, there's no mechanism for setting the Canvas Form title per component.
This commit adds that possibility by removing the
titleproperty from theVisualSchemainterface and provides helper methods to theIVisualizationNodeinterface so we can provide the title externally.By default, the
IDused to create the visualization node is used as the title.