fix(CanvasForm): Improvements over the ParametersField component
#1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
commented
Sep 26, 2024
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
|
|
||
| --pf-v5-c-table--cell--PaddingLeft: 0 !important; |
There was a problem hiding this comment.
Today is a sad day for the CSS folks, I'm sorry for doing this 😢
lordrip
force-pushed
the
fix/parameters-field
branch
2 times, most recently
from
cef73df to
60ebaa1
Compare
lordrip
changed the title
ParametersField component
lordrip
requested review from
igarashitm,
shivamG640 and
tplevko
and removed request for
igarashitm
igarashitm
approved these changes
Sep 30, 2024
lordrip
force-pushed
the
fix/parameters-field
branch
from
60ebaa1 to
3ed2df1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
=======================================
Coverage ? 69.11%
Complexity ? 26
=======================================
Files ? 275
Lines ? 7773
Branches ? 1541
=======================================
Hits ? 5372
Misses ? 2350
Partials ? 51 ☔ View full report in Codecov by Sentry. |
tplevko
approved these changes
Oct 1, 2024
Currently, the `PropertiesField` component overflows from the containing `Form`. This commit: * Reduces its padding * Changes the containing `Td` so it can limit the overflow * Extracts the `PropertiesFieldEmpty` state component * Add a few missing tests fix: KaotoIO#1473
lordrip
force-pushed
the
fix/parameters-field
branch
from
3ed2df1 to
8b4e6d4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This handles styling topics around the
PropertiesField.Improvements
Tdso it can limit the overflowfix: #1473