Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(1429): Supporting parameter notation and ceased URI parameters serialization #1493

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix(1429): Supporting parameter notation and ceased URI parameters serialization #1493

merged 1 commit into from
Oct 2, 2024

Conversation

shivamG640
Copy link
Contributor

@shivamG640 shivamG640 commented Sep 30, 2024 •
edited
Loading

Fixes #1429,
Changes can be tested here: https://shivamg640.github.io/kaoto/

@shivamG640 shivamG640 mentioned this pull request Sep 30, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f60222a). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1493   +/-   ##
=======================================
  Coverage        ?   68.83%           
  Complexity      ?       26           
=======================================
  Files           ?      275           
  Lines           ?     7713           
  Branches        ?     1510           
=======================================
  Hits            ?     5309           
  Misses          ?     2353           
  Partials        ?       51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivamG640 shivamG640 requested a review from lordrip September 30, 2024 14:56
@shivamG640 shivamG640 marked this pull request as ready for review September 30, 2024 16:31
@shivamG640 shivamG640 force-pushed the Fix-1429 branch 4 times, most recently from 988f2f5 to 7f50748 Compare October 1, 2024 11:10
lordrip
lordrip approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the duplication comes from test files, I think we can ignore the error message from sonar.

@shivamG640 shivamG640 force-pushed the Fix-1429 branch 3 times, most recently from 671f4ad to ade5f73 Compare October 1, 2024 16:51
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
43.5% Duplication on New Code (required ≤ 20%)

See analysis details on SonarCloud

lordrip
lordrip approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @shivamG640

@lordrip lordrip merged commit 458400e into KaotoIO:main Oct 2, 2024
11 of 12 checks passed
@shivamG640 shivamG640 deleted the Fix-1429 branch October 3, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing full URI in Endpoint's name generates bad YAML
2 participants
@shivamG640 @lordrip