chore(catalog-generator): Lower the required Java version to 17 #1520

lordrip · 2024-10-02T13:35:02Z

Context

Currently, the catalog-generator requires Java 21.

While that enables modern syntax, not all users have it installed in their machines, so in order to lower the contribution requirements, we're lowering the required version to be Java 17.

By default, in RHEL 9.0, Java 17 is preinstalled.

Here is an extract of the available Java version per RHEL version

RHEL Version	Java version	Release date
RHEL 7	Java 8	June 10, 2014
RHEL 8	Java 11	May 7, 2019
RHEL 9 👈 we're here	Java 17	May 17, 2022

fix: #1476

packages/catalog-generator/pom.xml

...s/catalog-generator/src/main/java/io/kaoto/camelcatalog/generator/CamelCatalogProcessor.java

apupier

usually a good practice to align the version used for the build on CI with the minimal one, for instance here

kaoto/.github/workflows/deploy-main.yml

Line 38 in 3907213

java-version: "21"

apupier · 2024-10-02T13:37:34Z

packages/catalog-generator/pom.xml

+            <configuration>
+              <rules>
+                <requireJavaVersion>
+                  <version>[17.0.0,17.0.999],[21.0.0,21.0.999]</version>


This will prevent users with Java 22+ to build. or even 21.1
I do no tthink that it is what we want

By reading version range rule defintion https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html, it seems like we are forbiding Java 17.1, 18, 19, 20 too

I think we should go with only 17

Mmm, didn't like it

[ERROR] Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion failed with message: [ERROR] Detected JDK version 17.0.12 (JAVA_HOME=/home/rmartinez/.sdkman/candidates/java/17.0.12-tem) is not in the allowed range [17,17].

I think it should be [1.0,)

no, 17 didn't work, I tried that one. I ended up using

strange, just 17 is working locally for me:

I think the problem was [17] getting extrapolated to [17,17]. I missed the 17 alone.

That was it, using 17 alone works with both 17 and 21

packages/catalog-generator/pom.xml

apupier · 2024-10-02T13:49:15Z

Shouldn't it be updated in the other Maven modules projects?

kaoto/packages/camel-catalog/pom.xml

Line 47 in 3907213

<version.java>21</version.java>

to avoid having a mix of minimal version of JDK

apupier · 2024-10-02T13:50:45Z

readme to update too

kaoto/CONTRIBUTING.md

Line 13 in 3907213

- Java 21+

lordrip · 2024-10-02T13:58:04Z

Shouldn't it be updated in the other Maven modules projects?

kaoto/packages/camel-catalog/pom.xml

Line 47 in 3907213

<version.java>21</version.java>

to avoid having a mix of minimal version of JDK

We don't use camel-catalog package anymore. We still have it because we're in the process of migrating the tests.

apupier · 2024-10-02T14:09:48Z

packages/catalog-generator/pom.xml

+            <configuration>
+              <rules>
+                <requireJavaVersion>
+                  <version>[17]</version>


not [17] but 17

or [17,) if you prefer to be more explicit and do no tuse the short notation

Currently, the `catalog-generator` requires Java 21. While that enable modern syntax, not all users have it installed in their machines, so in order to lower the contribution requirements, we're lowering the required version to be Java 17. By default, in RHEL 9.0, Java 17 is preinstalled. Here is an extract of the available Java version per RHEL version | RHEL Version | Java version | Release date | | --- | --- | --- | | RHEL 7 | Java 8 | June 10, 2014 | | RHEL 8 | Java 11 | May 7, 2019 | | RHEL 9 | Java 17 | May 17, 2022 | fix: KaotoIO#1476

sonarcloud · 2024-10-02T14:15:12Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lordrip · 2024-10-02T14:17:28Z

...ages/catalog-generator/src/test/java/io/kaoto/camelcatalog/commands/GenerateCommandTest.java

@@ -59,7 +59,7 @@ void testGeneratorCalledWithCorrectParameters() {
        })) {
            generateCommand.run();

-            CatalogGeneratorBuilder builder = mockedBuilder.constructed().getFirst();
+            CatalogGeneratorBuilder builder = mockedBuilder.constructed().get(0);


codecov · 2024-10-02T14:19:32Z

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@3907213). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
.../camelcatalog/generator/CamelCatalogProcessor.java	0.00%	15 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1520   +/-   ##
=======================================
  Coverage        ?   69.90%           
  Complexity      ?       62           
=======================================
  Files           ?      276           
  Lines           ?     7733           
  Branches        ?     1503           
=======================================
  Hits            ?     5406           
  Misses          ?     2277           
  Partials        ?       50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apupier · 2024-10-02T14:47:29Z

usually a good practice to align the version used for the build on CI with the minimal one, for instance here

kaoto/.github/workflows/deploy-main.yml

Line 38 in 3907213

java-version: "21"

I guess this part was forgotten.
It also ensures that when using Java 17 is really working.

lordrip requested review from apupier and igarashitm October 2, 2024 13:35

lordrip commented Oct 2, 2024

View reviewed changes

packages/catalog-generator/pom.xml Show resolved Hide resolved

lordrip commented Oct 2, 2024

View reviewed changes

...s/catalog-generator/src/main/java/io/kaoto/camelcatalog/generator/CamelCatalogProcessor.java Show resolved Hide resolved

apupier reviewed Oct 2, 2024

View reviewed changes

igarashitm approved these changes Oct 2, 2024

View reviewed changes

lordrip force-pushed the chore/lower2java17 branch from b225bc7 to 5b82976 Compare October 2, 2024 13:59

apupier reviewed Oct 2, 2024

View reviewed changes

lordrip force-pushed the chore/lower2java17 branch from 5b82976 to 8bd3058 Compare October 2, 2024 14:13

lordrip force-pushed the chore/lower2java17 branch from 8bd3058 to 015a433 Compare October 2, 2024 14:14

lordrip commented Oct 2, 2024

View reviewed changes

lordrip merged commit 5f7e7f3 into KaotoIO:main Oct 2, 2024
12 checks passed

lordrip deleted the chore/lower2java17 branch October 2, 2024 14:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(catalog-generator): Lower the required Java version to 17 #1520

chore(catalog-generator): Lower the required Java version to 17 #1520

lordrip commented Oct 2, 2024 •

edited

Loading

apupier left a comment

apupier Oct 2, 2024

apupier Oct 2, 2024

apupier Oct 2, 2024

lordrip Oct 2, 2024

lordrip Oct 2, 2024

lordrip Oct 2, 2024

apupier Oct 2, 2024

lordrip Oct 2, 2024

lordrip Oct 2, 2024

lordrip Oct 2, 2024

apupier commented Oct 2, 2024

apupier commented Oct 2, 2024

lordrip commented Oct 2, 2024

apupier Oct 2, 2024

apupier Oct 2, 2024

sonarcloud bot commented Oct 2, 2024

lordrip Oct 2, 2024

codecov bot commented Oct 2, 2024

apupier commented Oct 2, 2024

chore(catalog-generator): Lower the required Java version to 17 #1520

chore(catalog-generator): Lower the required Java version to 17 #1520

Conversation

lordrip commented Oct 2, 2024 • edited Loading

Context

apupier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apupier commented Oct 2, 2024

apupier commented Oct 2, 2024

lordrip commented Oct 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 2, 2024

Quality Gate passed

Choose a reason for hiding this comment

codecov bot commented Oct 2, 2024

Codecov Report

apupier commented Oct 2, 2024

lordrip commented Oct 2, 2024 •

edited

Loading