Define deleteContent API in ChannelEditor #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
=======================================
Coverage ? 69.90%
Complexity ? 62
=======================================
Files ? 276
Lines ? 7733
Branches ? 1474
=======================================
Hits ? 5406
Misses ? 2325
Partials ? 2 ☔ View full report in Codecov by Sentry. |
apupier
requested review from
a team,
igarashitm and
lordrip
and removed request for
a team
lordrip
reviewed
Oct 3, 2024
| * Delete resource | ||
| * @param path The path of the resource relatively to the currently edited Camel file | ||
| */ | ||
| deleteResource(path: string): Promise<string | undefined>; |
There was a problem hiding this comment.
[curious-question]
- What could be in the returned in the
string? - What about returning a
booleansignaling the operation's success?
There was a problem hiding this comment.
I went too fast. I implemented it with just Promise<void>, but we can return a boolean signaling the success.
let me update
relates to KaotoIO/vscode-kaoto#681 Signed-off-by: Aurélien Pupier <[email protected]>
apupier
force-pushed
the
addDeleteresourceAPIToChannelAPI
branch
from
e1a10cb to
fd9e160
Compare
|
lordrip
approved these changes
Oct 3, 2024
igarashitm
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to KaotoIO/vscode-kaoto#681