Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(catalog-generator): Bring previous tests #1530

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Oct 3, 2024

Context

Bring the previous tests from the camel-catalog package into catalog-generator package.

fix: #1250

@lordrip lordrip force-pushed the chore/bring-previous-catalog-tests branch from 94c6a9b to 1509db1 Compare October 3, 2024 14:22
@lordrip lordrip force-pushed the chore/bring-previous-catalog-tests branch 2 times, most recently from 9f8e1fa to d0fde1b Compare October 3, 2024 14:24
@lordrip lordrip force-pushed the chore/bring-previous-catalog-tests branch from d0fde1b to 5ebbaea Compare October 3, 2024 14:25
Copy link

sonarcloud bot commented Oct 3, 2024

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@cb1f68e). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage        ?   80.03%           
  Complexity      ?      258           
=======================================
  Files           ?      276           
  Lines           ?     7752           
  Branches        ?     1478           
=======================================
  Hits            ?     6204           
  Misses          ?     1489           
  Partials        ?       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip lordrip merged commit eff2de5 into KaotoIO:main Oct 3, 2024
12 checks passed
Comment on lines +40 to +44
<dependency>
<groupId>org.apache.camel</groupId>
<artifactId>camel-yaml-dsl</artifactId>
<version>${version.camel}</version>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen no changes of packages in the runtime code.
Shouldn't it be a test dependency? (or there was bug before? or I have missed the changes in runtime code requiring this dependency?)

Copy link
Member Author

@lordrip lordrip Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be a test dependency?

This is being used in tests, so yeah, if that's possible, then it would be better I think, how can be done?

or there was bug before?

No, there wasn't

@lordrip lordrip deleted the chore/bring-previous-catalog-tests branch October 3, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write the catalog files at the end of the process
3 participants