-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(catalog-generator): Bring previous tests #1530
chore(catalog-generator): Bring previous tests #1530
Conversation
94c6a9b
to
1509db1
Compare
9f8e1fa
to
d0fde1b
Compare
d0fde1b
to
5ebbaea
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
=======================================
Coverage ? 80.03%
Complexity ? 258
=======================================
Files ? 276
Lines ? 7752
Branches ? 1478
=======================================
Hits ? 6204
Misses ? 1489
Partials ? 59 ☔ View full report in Codecov by Sentry. |
<dependency> | ||
<groupId>org.apache.camel</groupId> | ||
<artifactId>camel-yaml-dsl</artifactId> | ||
<version>${version.camel}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen no changes of packages in the runtime code.
Shouldn't it be a test dependency? (or there was bug before? or I have missed the changes in runtime code requiring this dependency?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be a test dependency?
This is being used in tests, so yeah, if that's possible, then it would be better I think, how can be done?
or there was bug before?
No, there wasn't
Context
Bring the previous tests from the
camel-catalog
package intocatalog-generator
package.fix: #1250