fix(catalog-generator): Use Label or Group for the EIP parameters grouping #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
=======================================
Coverage ? 80.02%
Complexity ? 259
=======================================
Files ? 276
Lines ? 7755
Branches ? 1480
=======================================
Hits ? 6206
Misses ? 1489
Partials ? 60 ☔ View full report in Codecov by Sentry. |
igarashitm
approved these changes
Oct 3, 2024
shivamG640
approved these changes
Oct 3, 2024
lordrip
commented
Oct 4, 2024
| <groupId>org.apache.camel</groupId> | ||
| <artifactId>camel-yaml-dsl</artifactId> | ||
| <version>${version.camel}</version> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
Without having <scope>test</scope>, this forces the runtime to load the latest Camel YAML DSL schema, making the catalog generation fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Starting from Camel 4.5.0, the
labelproperty from EIP was renamed togroup.This PR handles that change and uses whatever is available at the moment of creating the catalog. In addition to that, it changed the scope of the
camel-yaml-dsldependency because it was forcing the catalog generator to use the latest YAML DSL schema, failing to generate older catalog versions.fix: #1381