Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Maven download log #1533

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

apupier
Copy link
Member

@apupier apupier commented Oct 4, 2024

On CI, the log cannot be correctly displayed and parsed in the GitHub default UI due to the large amount of it, mainly due to the download transfer progress of Maven components. Consequently, using --no-transfer-progress on the first Maven build to reduce the amount of logs.

Also updated Maven lifecycle phase, removed the verify phase as it is included in the install phase. See
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#a-build-lifecycle-is-made-up-of-phases for reference

On CI, the log cannot be correctly displayed and parsed in the GitHub
default UI due to the large amount of it, mainly due to the download
transfer progress of Maven components. Consequently, using
`--no-transfer-progress` on the first Maven build to reduce the amount
of logs.

Also updated Maven lifecycle phase, removed the verify phase as it is
included in the install phase. See
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#a-build-lifecycle-is-made-up-of-phases
for reference

Signed-off-by: Aurélien Pupier <[email protected]>
Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6a9d20d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1533   +/-   ##
=======================================
  Coverage        ?   80.02%           
  Complexity      ?      259           
=======================================
  Files           ?      276           
  Lines           ?     7755           
  Branches        ?     1520           
=======================================
  Hits            ?     6206           
  Misses          ?     1441           
  Partials        ?      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apupier
Copy link
Member Author

apupier commented Oct 4, 2024

it allows to go down from 13299 lines to 1450 lines

it allows the GitHub Ui to be responsive and find the test results a lot more easily https://github.com/KaotoIO/kaoto/actions/runs/11176290036/job/31069332593?pr=1533#step:7:146

@apupier apupier requested a review from lordrip October 4, 2024 08:33
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @apupier , it works way better

@apupier apupier merged commit 1ea7704 into KaotoIO:main Oct 4, 2024
12 checks passed
@apupier apupier deleted the reduceMavenDownloadLog branch October 4, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants