Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(form): Offer appropriate consumer/producer properties in the CanvasForm #1538

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

shivamG640
Copy link
Contributor

@shivamG640 shivamG640 commented Oct 4, 2024

Fixes #992 ,
Changes can be tested here: https://shivamg640.github.io/kaoto/

Before After
image image

Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6ebdd94). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1538   +/-   ##
=======================================
  Coverage        ?   80.04%           
  Complexity      ?      259           
=======================================
  Files           ?      276           
  Lines           ?     7761           
  Branches        ?     1482           
=======================================
  Hits            ?     6212           
  Misses          ?     1489           
  Partials        ?       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shivamG640 for taking care of this

@lordrip lordrip merged commit ff33a89 into KaotoIO:main Oct 7, 2024
12 checks passed
@shivamG640 shivamG640 deleted the Fix_992 branch October 7, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer appropriate consumer/producer properties in the CanvasForm
2 participants