Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1541): Provide a template for removeHeaders EIP #1546

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix(1541): Provide a template for removeHeaders EIP #1546

merged 1 commit into from
Oct 9, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Oct 9, 2024

fixes #1541

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f95f50e). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1546   +/-   ##
=======================================
  Coverage        ?   79.94%           
  Complexity      ?      259           
=======================================
  Files           ?      276           
  Lines           ?     7773           
  Branches        ?     1512           
=======================================
  Hits            ?     6214           
  Misses          ?     1451           
  Partials        ?      108

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tplevko tplevko marked this pull request as ready for review October 9, 2024 08:57
lordrip
lordrip approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care @tplevko, can we add a little test for this case? :)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tplevko
Copy link
Contributor Author

tplevko commented Oct 9, 2024

Thanks for taking care @tplevko, can we add a little test for this case? :)

Sure, just added a basic test

@lordrip
Copy link
Member

lordrip commented Oct 9, 2024

Thanks a lot @tplevko

@lordrip lordrip merged commit 5291966 into KaotoIO:main Oct 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a template for removeHeaders EIP
2 participants
@tplevko @lordrip