Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(catalog): Load required fields for Expressions, Data-formats and Load-balancers #1548

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

shivamG640
Copy link
Contributor

@shivamG640 shivamG640 commented Oct 9, 2024

Fixes #1443,

  • Before
    image
  • After
    image

@shivamG640 shivamG640 requested a review from lordrip October 9, 2024 11:04
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@bce3f44). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1548   +/-   ##
=======================================
  Coverage        ?   80.00%           
  Complexity      ?      263           
=======================================
  Files           ?      276           
  Lines           ?     7802           
  Branches        ?     1522           
=======================================
  Hits            ?     6242           
  Misses          ?     1452           
  Partials        ?      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 10, 2024

@shivamG640 shivamG640 changed the title Fix(catalog): Expressions does not show input expression field as required Fix(catalog): Load required fields for Expressions, Data-formats and Load-balancers Oct 10, 2024
@shivamG640 shivamG640 requested a review from lordrip October 10, 2024 07:51
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @shivamG640 for taking care, specially around improving the tests 👍

@lordrip lordrip merged commit 488112a into KaotoIO:main Oct 10, 2024
12 checks passed
@shivamG640 shivamG640 deleted the Fix_1443 branch October 10, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing a expression language does not show input box to type the actual expression
2 participants