feat(ConfigForm): Add support for oneOf fields #1551
Conversation
lordrip
requested review from
tplevko,
shivamG640,
igarashitm and
apupier
and removed request for
tplevko
| assertFalse(properties.has("langChain4jCharacterTokenizer")); | ||
| assertFalse(properties.has("langChain4jLineTokenizer")); | ||
| assertFalse(properties.has("langChain4jParagraphTokenizer")); | ||
| assertFalse(properties.has("langChain4jSentenceTokenizer")); | ||
| assertFalse(properties.has("langChain4jWordTokenizer")); |
There was a problem hiding this comment.
to help understand error failure, it is convenien tto provide an error message on the reason
| } | ||
|
|
||
| @Test | ||
| public void testRemoveEmptyProperties() throws Exception { |
There was a problem hiding this comment.
in JUnit 5, it is recommended to not use the the public modifier and keep default package
https://junit.org/junit5/docs/current/user-guide/#writing-tests-classes-and-methods
There was a problem hiding this comment.
Ok, I updated all tests to follow that convention
Currently, we have partial support for the `oneOf` schemas.
This commit cleans up the generated schemas, by removing the `not`
definition from `oneOf` and also removing the empty properties like:
'''
{
property: { }
}
'''
fix: KaotoIO#1550
fix: KaotoIO#948
lordrip
force-pushed
the
feat/support-for-oneof-fields
branch
from
80a26ff to
baf4bbd
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
=======================================
Coverage ? 80.02%
Complexity ? 272
=======================================
Files ? 276
Lines ? 7825
Branches ? 1496
=======================================
Hits ? 6262
Misses ? 1502
Partials ? 61 ☔ View full report in Codecov by Sentry. |
Adding support for In the past,
I wouldn't expect less 😅 |
Context
Currently, we have partial support for the
oneOfschemas.This commit cleans up the generated schemas, by removing the
notdefinition fromoneOfand also removing the empty properties like:Test the changes live: https://lordrip.github.io/kaoto/
fix: #1550
fix: #948