Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-close sidebar and unselect node on canvas click #1561

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

ibek
Copy link
Contributor

@ibek ibek commented Oct 10, 2024

fix: #606

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@f0ac182). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../ui/src/components/Visualization/Canvas/Canvas.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1561   +/-   ##
=======================================
  Coverage        ?   80.00%           
  Complexity      ?      272           
=======================================
  Files           ?      276           
  Lines           ?     7836           
  Branches        ?     1534           
=======================================
  Hits            ?     6269           
  Misses          ?     1458           
  Partials        ?      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 11, 2024

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ibek , this was a long awaited functionality :D

@lordrip lordrip merged commit c9f7a97 into KaotoIO:main Oct 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close configuration side panel when clicking elsewhere on the canvas
2 participants