Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-close sidebar and unselect node on canvas click #1561

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Auto-close sidebar and unselect node on canvas click #1561

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d255d4
Auto-close sidebar and unselect node on canvas click
ibek Oct 10, 2024
daae16c
Purposely omitted activeLayout update in Canvas
ibek Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/ui/src/components/Visualization/Canvas/Canvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,16 @@
setSelectedNode(undefined);
}, []);

const handleCanvasClick = useCallback(
(event: React.MouseEvent) => {
const target = event.target as HTMLElement;
if (target.tagName === 'rect') {
handleCloseSideBar();

Check warning on line 197 in packages/ui/src/components/Visualization/Canvas/Canvas.tsx

View check run for this annotation

Codecov / codecov/patch

packages/ui/src/components/Visualization/Canvas/Canvas.tsx#L197 

Added line #L197 was not covered by tests
}
},
[handleCloseSideBar],
);

const isSidebarOpen = useMemo(() => selectedNode !== undefined, [selectedNode]);

return (
Expand All @@ -203,6 +213,7 @@
sideBar={<CanvasSideBar selectedNode={selectedNode} onClose={handleCloseSideBar} />}
contextToolbar={contextToolbar}
controlBar={<TopologyControlBar controlButtons={controlButtons} />}
onClick={handleCanvasClick}
>
<VisualizationSurface state={{ selectedIds }} />

Expand Down
Loading