Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat #1117: Add EnableAll menu item when routes include multiple disabled steps #1568

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ibek
Copy link
Contributor

@ibek ibek commented Oct 11, 2024

fix: #1117

@ibek
Copy link
Contributor Author

ibek commented Oct 11, 2024

Screencast.from.2024-10-11.15-35-43.webm

Copy link

sonarcloud bot commented Oct 12, 2024

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c9f7a97). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...sualization/Custom/ContextMenu/ItemDisableStep.tsx 58.33% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1568   +/-   ##
=======================================
  Coverage        ?   79.94%           
  Complexity      ?      272           
=======================================
  Files           ?      276           
  Lines           ?     7859           
  Branches        ?     1541           
=======================================
  Hits            ?     6283           
  Misses          ?     1467           
  Partials        ?      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip lordrip changed the title feat #1117: Add EnableAll menu item when routes include multiple disa… feat #1117: Add EnableAll menu item when routes include multiple disabled steps Oct 14, 2024
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibek, thanks for the contribution, I ran the code, and it works fine, there are a couple of topics around the typings and stuff, but I can take care of them afterward.

I'm gonna merge the PR now but I wanted to ask you, would it be ok from your POV to have this Enable all entry at all times, regardless of having disabled elements?

The reason is since we're iterating over all nodes, this could be an expensive operation at some point, slowing down the contextual menu, sure, this only would happen for slower computers + big YAML definitions, but I think we have seen a few cases like that in the past 😃.

Please let me know what you think and I'll refactor it later. Once again thanks for taking the time to check this.

@lordrip lordrip merged commit 9457ddc into KaotoIO:main Oct 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to quickly enable all disabled steps (enable all)
2 participants