Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Canvas): Add quick icon edge end #1571

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feat(Canvas): Add quick icon edge end #1571

merged 2 commits into from
Oct 17, 2024

Conversation

ibek
Copy link
Contributor

@ibek ibek commented Oct 13, 2024

Horizontal Vertical
image image

fix: #1540

@ibek
Copy link
Contributor Author

ibek commented Oct 13, 2024

Screencast.from.2024-10-13.18-32-41.webm

@lordrip
Copy link
Member

lordrip commented Oct 14, 2024

I like this a lot, I'm checking it in the vertical layout but it seems we should place the icon below the label.

Do you see another option?
image

@ibek
Copy link
Contributor Author

ibek commented Oct 14, 2024

Thank you @lordrip . For now I would keep it this way until we merge #1562 which suggests to place the labels on the right and then I can update the quick icon to be placed down which won't overlap like it would now.

@ibek ibek force-pushed the feat-1540 branch 2 times, most recently from 8c5dd6b to d87fbcd Compare October 14, 2024 20:38
@ibek
Copy link
Contributor Author

ibek commented Oct 14, 2024

As we discussed on Slack this is how it looks now in horizontal and vertical view:
Screenshot from 2024-10-14 22-36-55
Screenshot from 2024-10-14 20-39-39

@lordrip
Copy link
Member

lordrip commented Oct 17, 2024

Horizontal

image

Vertical

image

@lordrip lordrip requested review from igarashitm and tplevko October 17, 2024 14:18
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 27 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@2e6d8e6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../components/Visualization/Custom/NoBendingEdge.tsx 65.21% 16 Missing ⚠️
...s/Visualization/Custom/ContextMenu/ItemAddStep.tsx 42.85% 7 Missing and 1 partial ⚠️
...c/components/Visualization/Custom/Edge/EdgeEnd.tsx 86.36% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1571   +/-   ##
=======================================
  Coverage        ?   79.91%           
  Complexity      ?      272           
=======================================
  Files           ?      279           
  Lines           ?     7995           
  Branches        ?     1557           
=======================================
  Hits            ?     6389           
  Misses          ?     1495           
  Partials        ?      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 17, 2024

@lordrip lordrip changed the title feat #1540: Add quick icon edge end feat(Canvas): Add quick icon edge end Oct 17, 2024
@lordrip lordrip merged commit da73c38 into KaotoIO:main Oct 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide quick action icons in the canvas' nodes
3 participants