fix(Canvas): Fix Edge source misplaced for containers #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
fix/edge-source-misplaced
branch
from
91242a0 to
5c21d0e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
=======================================
Coverage ? 79.91%
Complexity ? 272
=======================================
Files ? 280
Lines ? 7998
Branches ? 1527
=======================================
Hits ? 6392
Misses ? 1545
Partials ? 61 ☔ View full report in Codecov by Sentry. |
lordrip
force-pushed
the
fix/edge-source-misplaced
branch
from
5c21d0e to
77abc76
Compare
In order to make room for the node's secondary label, the containers were expanded by `10px`. The problem comes when in vertical layout, that additional size is not taken into account when calculating the edges since the size is only reflected in the visualization part and not during the layout calculation. The solution for now is to increase the group padding just a bit to make the secondary label to fit. fix: KaotoIO#1575
lordrip
force-pushed
the
fix/edge-source-misplaced
branch
from
77abc76 to
6ccbca9
Compare
|
igarashitm
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order to make room for the node's secondary label, the containers were expanded by
10px.The problem comes when in vertical layout, that additional size is not taken into account when calculating the edges since the size is only reflected in the visualization part and not during the layout calculation.
The solution for now is to increase the group padding just a bit to make the secondary label to fit.
fix: #1575