Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update embedded catalog from 4.8.0 to 4.8.1 #1596

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

apupier
Copy link
Member

@apupier apupier commented Oct 28, 2024

No description provided.

@apupier apupier added this to the 2.3.0 milestone Oct 29, 2024
@apupier
Copy link
Member Author

apupier commented Oct 30, 2024

test are failing due to snapshots not updated.
How can we update them?
Tried yarn workspaces foreach --verbose --all --topological-dev run test -- -u and yarn workspaces foreach --verbose --all --topological-dev run test -U

EDIT: what's better to ask to finally find the information in the documentation https://jestjs.io/docs/snapshot-testing#updating-snapshots ,--updateSnapshot

Copy link

sonarcloud bot commented Oct 30, 2024

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@391c343). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1596   +/-   ##
=======================================
  Coverage        ?   79.98%           
  Complexity      ?      273           
=======================================
  Files           ?      280           
  Lines           ?     8004           
  Branches        ?     1573           
=======================================
  Hits            ?     6402           
  Misses          ?     1492           
  Partials        ?      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apupier apupier requested a review from a team October 30, 2024 10:35
@lordrip lordrip merged commit 39c0ffd into KaotoIO:main Oct 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants