Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(DND): Enable Simple DND #1620

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shivamG640
Copy link
Contributor

@shivamG640 shivamG640 commented Nov 15, 2024

Fixes #80 partially

Current Status

Done:

  • Enabled DND of nodes over other nodes and groups(not all processors).
  • Enabled containers drag only when collapsed.
  • Added Visual Feedback when DND on groups and nodes.

Above changes can be tested live here.

Pending:

  • Enable drop on groups like choice, dotry processor
  • Enable drop on a specific container in case of multiple level of nested container. Currently dragged node can only goes to the same level container.
  • Enable container drag without the need of collapsing.
  • Add enable/disable DND feature on settings page.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 34.01361% with 97 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4d8d775). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...omponents/Visualization/Custom/Node/CustomNode.tsx 57.35% 29 Missing ⚠️
...isualization/flows/abstract-camel-visual-entity.ts 0.00% 25 Missing ⚠️
...c/models/visualization/flows/pipe-visual-entity.ts 0.00% 19 Missing ⚠️
.../ui/src/models/visualization/visualization-node.ts 0.00% 7 Missing ⚠️
...ization/flows/camel-error-handler-visual-entity.ts 0.00% 6 Missing ⚠️
...on/flows/camel-rest-configuration-visual-entity.ts 0.00% 6 Missing ⚠️
...Visualization/Custom/Group/CustomGroupExpanded.tsx 66.66% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1620   +/-   ##
=======================================
  Coverage        ?   83.10%           
  Complexity      ?      365           
=======================================
  Files           ?      284           
  Lines           ?     8259           
  Branches        ?     1630           
=======================================
  Hits            ?     6864           
  Misses          ?     1307           
  Partials        ?       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivamG640 shivamG640 force-pushed the Feat-Simple-DND branch 5 times, most recently from 99a12be to 5e1e2c0 Compare December 4, 2024 09:20
Copy link

sonarcloud bot commented Dec 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder nodes using drag and drop
1 participant