chore(ui): Remove direct catalog usage #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we're using the catalog at runtime by:
```
import catalogIndex from '@kaoto-next/camel-catalog/index.json?url';
```
While it works, the problem with this approach is that we're tying
the @kaoto-next/camel-catalog dependency at runtime.
The change is to leverage the vite build step in which the catalog
is copied to the `assets` folder.
```
fetch(`.${DEFAULT_CATALOG_PATH}/index.json`)
```
Relates to: KaotoIO#131
lordrip
force-pushed
the
chore/remove-catalog-direct-usage
branch
from
59bdaf9 to
5f5aba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, we're using the catalog at runtime by:
While it works, the problem with this approach is that we're tying the @kaoto-next/camel-catalog dependency at runtime.
Changes
The change is to leverage the vite build step in which the catalog is copied to the
assetsfolder.Relates to: #131