fix(FLowsList): Evaluate action confirmation when deleting a Flow #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhein
approved these changes
Nov 26, 2024
Currently, when deleting a flow, the confirmation modal is not properly evaluated, leading to always deleting the flow regardless of the user choice. The fix is to check the return of the modal and act in consequence. fix: KaotoIO#1660
lordrip
force-pushed
the
fix/cancel-delete-route
branch
from
9e1bd9a to
54bcb82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
=======================================
Coverage ? 84.02%
Complexity ? 365
=======================================
Files ? 284
Lines ? 8145
Branches ? 1606
=======================================
Hits ? 6844
Misses ? 1162
Partials ? 139 ☔ View full report in Codecov by Sentry. |
apupier
approved these changes
Nov 26, 2024
tplevko
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, when deleting a flow, the confirmation modal is not properly evaluated, leading to always deleting the flow regardless of the user's choice.
Changes
The fix is to check the return of the modal and act in consequence.
fix: #1660