feat(Canvas): Improve add steps into canvas #1673
Conversation
lordrip
force-pushed
the
feat/add-step-placeholder
branch
4 times, most recently
from
f90dd63 to
d376281
Compare
lordrip
changed the title
lordrip
force-pushed
the
feat/add-step-placeholder
branch
2 times, most recently
from
b4e1fd0 to
8cf7b33
Compare
lordrip
requested review from
igarashitm,
lhein,
apupier,
ibek,
tplevko,
mmelko and
shivamG640
lordrip
force-pushed
the
feat/add-step-placeholder
branch
from
8cf7b33 to
e911ad6
Compare
Currently, we have 3 alternative mechanisms for adding new steps in the canvas: 1. Right click on a node and select between `Prepend`, `Append`, and `Insert`. 2. Use the Step Toolbar to `Insert` 3. Use the quick add edge. This commit replaces the quick add edge with a floating button over the last element of the route. In addition to that, it generates a placeholder when the steps property is empty, so the user can quickly add a new step to initialize the branch.
lordrip
force-pushed
the
feat/add-step-placeholder
branch
from
e911ad6 to
1735e95
Compare
| @@ -141,7 +141,7 @@ export abstract class AbstractCamelVisualEntity<T extends object> implements Bas | |||
| /** If we're in Replace mode, we need to delete the existing step */ | |||
| const deleteCount = options.mode === AddStepMode.ReplaceStep ? 1 : 0; | |||
|
|
|||
| const stepsArray: ProcessorDefinition[] = getValue(this.entityDef, pathArray.slice(0, -2), []); | |||
There was a problem hiding this comment.
This was the root cause of the bug preventing adding steps in EIPs with steps: undefined, like multicast or filter.
The problem was that for array properties (like steps) that don't exist by default, for instance, when adding a multicast, aggregate or filter, Kaoto doesn't offer a template with the steps property already created, the code creates a new array but it doesn't assign it to the object, therefore, the step gets assigned to a newly created array completely detached from the Camel Route structure.
The fix is to use the getArrayProperty which ensures the requested array, regardless of whether it exists or not, is properly attached to the structure.
Since the StepToolbar `+` button was removed in favor of using a placeholder node or the `arrow` icon, we no longer need to disable the node interactions for parallel EIPs like `multicast` and loadBalance`
|
Context
Currently, we have 3 alternative mechanisms for adding new steps in the canvas:
Prepend,Append, andInsert.InsertChanges
This commit replaces the quick add edge with a floating button over the last element of the route. In addition to that, it generates a placeholder when the steps property is empty, so the user can quickly add a new step to initialize the branch.
Notes
fix: #1648
fix: #1647
fix: #1072