Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update quarkus versions #1698

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Dec 9, 2024

Changes

  1. Separate each version into its own line, so we avoid conflicts whenever versions are updated in separate PRs
  2. Align Quarkus versions to the "Last version, latest 2 LTS versions" approach
  3. Add comments about what underlying Camel version is embedded in the Quarkus version

Notes

Output of the camel version list --fresh --runtime=quarkus command

$ camel version list --fresh --runtime=quarkus

 CAMEL VERSION   QUARKUS    JDK   KIND     RELEASED     SUPPORTED UNTIL 
     ...   
     4.4.2        3.8.2    17,21  LTS         May 2024    February 2025 
     4.4.3        3.8.3    17,21  LTS        July 2024    February 2025 
     4.4.4        3.8.4    17,21  LTS    November 2024    February 2025 
     4.5.0       3.10.0    17,21            April 2024                  
     4.6.0       3.11.0    17,21              May 2024                  
     4.6.0       3.12.0    17,21             June 2024                  
     4.7.0       3.13.0    17,21             July 2024                  
     4.7.0       3.14.0    17,21           August 2024                  
     4.8.0       3.15.0    17,21  LTS   September 2024   September 2025 
     4.8.1       3.15.1    17,21  LTS    November 2024   September 2025 
     4.8.1       3.16.0    17,21          October 2024                  
     4.9.0       3.17.0                                                 

@lordrip lordrip requested review from apupier and lhein December 9, 2024 09:35
Copy link

sonarcloud bot commented Dec 9, 2024

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3e77017). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1698   +/-   ##
=======================================
  Coverage        ?   84.32%           
  Complexity      ?      365           
=======================================
  Files           ?      287           
  Lines           ?     8208           
  Branches        ?     1629           
=======================================
  Hits            ?     6921           
  Misses          ?     1198           
  Partials        ?       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip
Copy link
Member Author

lordrip commented Dec 9, 2024

Failing for Quarkus 3.17.0 with

Dec 09, 2024 10:58:15 AM io.kaoto.camelcatalog.commands.GenerateCommand lambda$run$0
INFO: Generating catalog: Quarkus 3.17.0

Dec 09, 2024 10:58:17 AM io.kaoto.camelcatalog.maven.CamelCatalogVersionLoader loadCamelYamlDsl
SEVERE: No schema/camelYamlDsl.json file found in the classpath
Dec 09, 2024 10:58:17 AM io.kaoto.camelcatalog.generator.CatalogGenerator processCamelSchema
SEVERE: Camel YAML DSL JSON Schema is not loaded
Dec 09, 2024 10:58:17 AM io.kaoto.camelcatalog.generator.CatalogGenerator processCatalog
SEVERE: java.lang.NullPointerException: Cannot invoke "io.kaoto.camelcatalog.generator.CamelYamlDslSchemaProcessor.getDataFormats()" because "this.schemaProcessor" is null
java.lang.NullPointerException: Cannot invoke "io.kaoto.camelcatalog.generator.CamelYamlDslSchemaProcessor.getDataFormats()" because "this.schemaProcessor" is null
	at io.kaoto.camelcatalog.generator.CamelCatalogProcessor.getDataFormatCatalog(CamelCatalogProcessor.java:210)
	at io.kaoto.camelcatalog.generator.CamelCatalogProcessor.processCatalog(CamelCatalogProcessor.java:72)
	at io.kaoto.camelcatalog.generator.CatalogGenerator.processCatalog(CatalogGenerator.java:187)
	at io.kaoto.camelcatalog.generator.CatalogGenerator.generate(CatalogGenerator.java:70)
	at io.kaoto.camelcatalog.commands.GenerateCommand.lambda$run$0(GenerateCommand.java:52)
	at java.base/java.lang.Iterable.forEach(Iterable.java:75)
	at io.kaoto.camelcatalog.commands.GenerateCommand.run(GenerateCommand.java:36)
	at io.kaoto.camelcatalog.Main.main(Main.java:28)

@lordrip
Copy link
Member Author

lordrip commented Dec 9, 2024

YAML DSL is still syncing to central: https://repo1.maven.org/maven2/org/apache/camel/quarkus/camel-quarkus-yaml-dsl/

Edit: The 3.17.0 version is available now.

@lordrip lordrip marked this pull request as ready for review December 9, 2024 11:31
@lhein lhein merged commit 5a07676 into KaotoIO:main Dec 9, 2024
14 checks passed
@lordrip lordrip deleted the chore/update-quarkus-versions branch December 9, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants