Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DataMapper #1700

Merged
merged 514 commits into from
Dec 9, 2024
Merged

Merge DataMapper #1700

merged 514 commits into from
Dec 9, 2024

Conversation

igarashitm
Copy link
Contributor

No description provided.

renovate bot and others added 30 commits July 9, 2024 13:13
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 73.57777% with 1398 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (ee59ee4) to head (001a9b4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/xml-schema-ts/src/SchemaBuilder.ts 49.17% 461 Missing ⚠️
packages/xml-schema-ts/src/XmlSchema.ts 39.46% 135 Missing ⚠️
packages/xml-schema-ts/src/XmlSchemaCollection.ts 66.00% 86 Missing ⚠️
...ges/xml-schema-ts/src/XmlSchemaDerivationMethod.ts 27.05% 62 Missing ⚠️
...ges/ui/src/services/datamapper-metadata.service.ts 42.69% 51 Missing ⚠️
...es/ui/src/multiplying-architecture/KaotoBridge.tsx 19.14% 38 Missing ⚠️
packages/ui/src/components/View/MappingLink.tsx 57.31% 35 Missing ⚠️
packages/xml-schema-ts/src/XmlSchemaNotation.ts 0.00% 35 Missing ⚠️
.../xml-schema-ts/src/attribute/XmlSchemaAttribute.ts 52.77% 34 Missing ⚠️
packages/xml-schema-ts/src/XmlSchemaType.ts 52.08% 23 Missing ⚠️
... and 64 more
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1700   +/-   ##
=========================================
  Coverage     78.62%   78.62%           
  Complexity      365      365           
=========================================
  Files           439      439           
  Lines         14234    14234           
  Branches       2688     2769   +81     
=========================================
  Hits          11191    11191           
  Misses         2954     2954           
  Partials         89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yarn.lock Show resolved Hide resolved
`yarn vite .`

#### Or from Kaoto `packages/ui` directory
`yarn vite src/components/DataMapper/debug`
Copy link
Member

@apupier apupier Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it i not working for me:

(base) apupier@localhost:~/git/kaoto-next/packages/ui$ yarn vite src/components/DataMapper/debug

  VITE v5.4.0  ready in 178 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
Error:   Failed to scan for dependencies from entries:
  /home/apupier/git/kaoto-next/packages/ui/src/components/DataMapper/debug/index.html

  ✘ [ERROR] Failed to resolve entry for package "@kaoto/xml-schema-ts". The package may have incorrect main/module/exports specified in its package.json. [plugin vite:dep-scan]
The plugin "vite:dep-scan" was triggered by this import

  src/services/xml-schema-document.service.ts:31:7:
    31 │ } from '@kaoto/xml-schema-ts';
       ╵        ~~~~~~~~~~~~~~~~~~~~~~


  at failureErrorWithLog (/home/apupier/git/kaoto-next/node_modules/esbuild/lib/main.js:1472:15)
  at /home/apupier/git/kaoto-next/node_modules/esbuild/lib/main.js:945:25
  ```

### How to use

#### In this directory
`yarn vite .`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igarashitm , here we need to refer to the preparation instructions in the README.md

</head>
<body>
<script type="module">
// Temporary workaround for @patternfly/react-topology using global
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it still necessary? Which issue must be fixed to remove it? What about including the related patternfly issue in the comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not, if I'm not mistaken this should have been fixed in topology upstream. In any case, this is a debug component that it's not part of Kaoto, so we can skip it for now.

@igarashitm igarashitm marked this pull request as ready for review December 9, 2024 17:35
…stall script

Also excluded it from GitHub workflow build
@@ -26,7 +26,7 @@
"typescript": "5.5.4"
},
"scripts": {
"postinstall": "yarn workspace @kaoto/camel-catalog run build",
"postinstall": "yarn workspace @kaoto/camel-catalog run build && yarn workspace @kaoto/xml-schema-ts run build",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can run the build process in both packages at the same time, but let's check it after this PR

Copy link

sonarcloud bot commented Dec 9, 2024

@igarashitm igarashitm merged commit 665b146 into KaotoIO:main Dec 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants