-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge DataMapper #1700
Merge DataMapper #1700
Conversation
Fixes: KaotoIO#121 Fixes: KaotoIO#290
`yarn vite .` | ||
|
||
#### Or from Kaoto `packages/ui` directory | ||
`yarn vite src/components/DataMapper/debug` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it i not working for me:
(base) apupier@localhost:~/git/kaoto-next/packages/ui$ yarn vite src/components/DataMapper/debug
VITE v5.4.0 ready in 178 ms
➜ Local: http://localhost:5173/
➜ Network: use --host to expose
➜ press h + enter to show help
Error: Failed to scan for dependencies from entries:
/home/apupier/git/kaoto-next/packages/ui/src/components/DataMapper/debug/index.html
✘ [ERROR] Failed to resolve entry for package "@kaoto/xml-schema-ts". The package may have incorrect main/module/exports specified in its package.json. [plugin vite:dep-scan]
The plugin "vite:dep-scan" was triggered by this import
src/services/xml-schema-document.service.ts:31:7:
31 │ } from '@kaoto/xml-schema-ts';
╵ ~~~~~~~~~~~~~~~~~~~~~~
at failureErrorWithLog (/home/apupier/git/kaoto-next/node_modules/esbuild/lib/main.js:1472:15)
at /home/apupier/git/kaoto-next/node_modules/esbuild/lib/main.js:945:25
```
### How to use | ||
|
||
#### In this directory | ||
`yarn vite .` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not working wih same error than https://github.com/KaotoIO/kaoto/pull/1700/files#r1876206691
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igarashitm , here we need to refer to the preparation instructions in the README.md
</head> | ||
<body> | ||
<script type="module"> | ||
// Temporary workaround for @patternfly/react-topology using global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it still necessary? Which issue must be fixed to remove it? What about including the related patternfly issue in the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not, if I'm not mistaken this should have been fixed in topology upstream. In any case, this is a debug component that it's not part of Kaoto, so we can skip it for now.
packages/ui/src/components/Document/actions/DetachSchemaButton.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Lars Heinemann <[email protected]>
…stall script Also excluded it from GitHub workflow build
@@ -26,7 +26,7 @@ | |||
"typescript": "5.5.4" | |||
}, | |||
"scripts": { | |||
"postinstall": "yarn workspace @kaoto/camel-catalog run build", | |||
"postinstall": "yarn workspace @kaoto/camel-catalog run build && yarn workspace @kaoto/xml-schema-ts run build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can run the build process in both packages at the same time, but let's check it after this PR
Quality Gate passedIssues Measures |
No description provided.