Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(viz): Remove nodes from the canvas #222

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Oct 16, 2023

Context

This pull request adds the possibility to remove individual nodes from an integration, currently, it supports Camel Routes only

Screencast

Screencast.from.2023-10-16.15-50-06.webm

Notes

  • The otherwise property from the choice node remains due to a configuration in the VisualizationNode class, we'll tackle this in a separate pull request.
  • Removing nodes from Pipe and KameletBinding is waiting until we receive the entire flow into the PieVisualEntity class

Fixes: #78

@lordrip lordrip requested a review from a team October 16, 2023 13:51
@lordrip lordrip force-pushed the feat/remove-nodes branch 6 times, most recently from c37bc37 to eebbcd6 Compare October 17, 2023 10:39
This pull request adds the possibility to remove individual nodes from an integration, currently, it supports `Camel Routes` only

Notes:
* The `otherwise` property from the `choice` node remains due to a configuration in the `VisualizationNode` class, we'll tackle this in a separate pull request.
* Removing nodes from `Pipe` and `KameletBinding` is waiting until we receive the entire flow into the `PieVisualEntity` class

Fixes: KaotoIO#78
@lordrip lordrip merged commit ee63d54 into KaotoIO:main Oct 17, 2023
2 checks passed
@lordrip lordrip deleted the feat/remove-nodes branch October 17, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove nodes from the canvas
2 participants