chore(lint): Make lint mandatory for UI package #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
chore/fix-lint-script
branch
2 times, most recently
from
be34371 to
5631f2d
Compare
Currently, both lint:code and lint:style are optional as both are run with `;` syntax, meaning that if lint:code fails, and stylelint doesn't, the stage is passed as only the last exit code gets stored. The fix is to separate both scripts and execute them in dedicated stages.
lordrip
force-pushed
the
chore/fix-lint-script
branch
from
5631f2d to
dd2c91b
Compare
shivamG640
approved these changes
Nov 17, 2023
|
thanks for reviewing it @shivamG640 💪 |
lordrip
pushed a commit
to lordrip/kaoto
that referenced
this pull request
Aug 30, 2024
Fixes: KaotoIO#360 Fixes: KaotoIO#363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, both
lint:codeandlint:styleare optional as both are run with;syntax, meaning that iflint:codefails, butstylelintdoesn't, the stage is passed as only the last exit code gets stored.Changes
The fix is to separate both scripts and execute them in dedicated stages.